Skip to content

Bump custom-metrics-apiserver version to v1.32.0#6344

Merged
karmada-bot merged 1 commit intokarmada-io:masterfrom
seanlaii:upgrade-custom-metrics
May 6, 2025
Merged

Bump custom-metrics-apiserver version to v1.32.0#6344
karmada-bot merged 1 commit intokarmada-io:masterfrom
seanlaii:upgrade-custom-metrics

Conversation

@seanlaii
Copy link
Copy Markdown
Contributor

@seanlaii seanlaii commented May 1, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bump custom-metrics-apiserver with an official release with Kubernetes dependencies v0.32.0 to include k8s dependencies 0.32.

Which issue(s) this PR fixes:
Part of #6310

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 1, 2025
@karmada-bot karmada-bot requested review from Poor12 and jwcesign May 1, 2025 01:46
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 1, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 1, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (c5b2d3c) to head (d14e17c).
⚠️ Report is 992 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6344   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files         678      678           
  Lines       55050    55050           
=======================================
  Hits        27167    27167           
  Misses      26115    26115           
  Partials     1768     1768
Flag Coverage Δ
unittests 49.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seanlaii
Copy link
Copy Markdown
Contributor Author

seanlaii commented May 1, 2025

/retest

@RainbowMango
Copy link
Copy Markdown
Member

RainbowMango commented May 3, 2025

Need a rebase for the conflicts~

@RainbowMango RainbowMango mentioned this pull request May 3, 2025
Closed
8 tasks
@seanlaii
Bump custom-metrics-apiserver version to v1.32.0
d14e17c 
Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@seanlaii seanlaii force-pushed the upgrade-custom-metrics branch from 79c8cd0 to d14e17c Compare May 3, 2025 19:15
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2025
@seanlaii
Copy link
Copy Markdown
Contributor Author

seanlaii commented May 3, 2025

Rebased. Thanks for the review!

RainbowMango
RainbowMango approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@karmada-bot
Copy link
Copy Markdown
Contributor

karmada-bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@karmada-bot karmada-bot merged commit 669dac4 into karmada-io:master May 6, 2025
24 checks passed
@seanlaii seanlaii deleted the upgrade-custom-metrics branch May 6, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@jwcesign jwcesign Awaiting requested review from jwcesign

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@RainbowMango RainbowMango

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seanlaii @codecov-commenter @RainbowMango @karmada-bot